Skip to content

Add namespace access for list and rotate keys - #10211

Open
Jessie (techworldhello) wants to merge 1 commit into
Azure:mainfrom
techworldhello:wangjessi/namespace-access
Open

Add namespace access for list and rotate keys#10211
Jessie (techworldhello) wants to merge 1 commit into
Azure:mainfrom
techworldhello:wangjessi/namespace-access

Conversation

@techworldhello

@techworldhello Jessie (techworldhello) commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes
⚠️ None
⚠️Azure CLI Extensions Breaking Change Test
⚠️aimanager
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd aimanager namespace list-accesskeys cmd aimanager namespace list-accesskeys added
⚠️ 1001 - CmdAdd aimanager namespace rotate-accesskeys cmd aimanager namespace rotate-accesskeys added

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Add namespace access for list and rotate keys

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI lite review requested due to automatic review settings August 13, 2026 01:07
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Jessie (@techworldhello),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new az aimanager namespace commands to retrieve and rotate namespace access keys, including CLI parameter wiring, help text, and a scenario test to validate behavior and header propagation.

Changes:

  • Added aimanager namespace list-accesskeys and aimanager namespace rotate-accesskeys commands.
  • Implemented corresponding custom handlers that pass through --aks-custom-headers.
  • Added help entries and a scenario test covering both commands.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aimanager/azext_aimanager/tests/latest/test_namespace_accesskeys_scenario.py New scenario test validating list/rotate access keys and custom header propagation.
src/aimanager/azext_aimanager/custom.py Adds custom command implementations for listing and rotating namespace access keys.
src/aimanager/azext_aimanager/commands.py Registers the new namespace access-keys commands in the command table.
src/aimanager/azext_aimanager/_params.py Wires --aks-custom-headers into the new command scopes.
src/aimanager/azext_aimanager/_help.py Adds CLI help and examples for the new commands.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants