Skip to content

Add OpenTelemetry baggage propagation - #890

Open
Arnab Nandy (arnabnandy7) wants to merge 1 commit into
Azure:devfrom
arnabnandy7:feature/opentelemetry-baggage
Open

Add OpenTelemetry baggage propagation#890
Arnab Nandy (arnabnandy7) wants to merge 1 commit into
Azure:devfrom
arnabnandy7:feature/opentelemetry-baggage

Conversation

@arnabnandy7

Copy link
Copy Markdown

Issue describing the changes in this PR

Resolves #866

This PR adds worker-side support for OpenTelemetry Baggage propagation by:

  • Adding the baggage map from language worker protobuf v1.13.0 to RpcTraceContext.
  • Passing baggage received from the Functions host into ExecutionTraceContext.
  • Exposing the baggage values through ExecutionTraceContext#getBaggage().
  • Adding unit coverage for non-empty, empty, and null baggage values.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

The public TraceContext interface in azure-functions-java-core-library does not currently expose a baggage accessor. A coordinated core-library update is required to add getBaggage() to the customer-facing API. Once that version is released, the worker dependency can be updated and ExecutionTraceContext#getBaggage() can explicitly override the interface method.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support OpenTelemetry Baggage

1 participant