You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug: Stable release becomes outdated very quickly due to hard coding #188
You appear to set a stableHelmVersion in run.ts. That's problematic because the stable version changes frequently so this action quickly ends up with an outdated stable version.
This got worse when Helm 4 shipped, and it is worth separating from the staleness issue.
When this was filed, the hard-coded fallback kept users inside Helm 3, so the cost was a missing flag. Now latest resolves to Helm 4, and the same fallback moves a job back a whole major on a single failed request. The step stays green and the run fails later on something unrelated-looking, in our case Error: unknown flag: --rollback-on-failure.
I don't think we should fallback to another version. If fetching the latest version fails, then just fail? Or retry a few times first, but then fail with the actual error?
I'm still of the opinion that hard-coding a fallback version is not the best design, and that the action should simply fail and not magically fallback to another version. But at least we can opt-out of the behaviour now :)
Activity
corneliusroemer commentedon Jun 20, 2025
You probably shouldn't use that "stable" version as a hardcoded string in tests as well - that means updating it causes test failure...
setup-helm/src/run.test.ts
Line 91 in df342a2
davidgamero commentedon Mar 25, 2026
the linked file mentions:
the variable linked is only used if the current stable version cannot be detected with a network call
the name "stableHelmVersion" could be ambiguous as you mentioned, and a PR would be welcome to fix it 😄
thomastvedt commentedon Sep 10, 2026
This got worse when Helm 4 shipped, and it is worth separating from the staleness issue.
When this was filed, the hard-coded fallback kept users inside Helm 3, so the cost was a missing flag. Now
latestresolves to Helm 4, and the same fallback moves a job back a whole major on a single failed request. The step stays green and the run fails later on something unrelated-looking, in our caseError: unknown flag: --rollback-on-failure.I don't think we should fallback to another version. If fetching the latest version fails, then just fail? Or retry a few times first, but then fail with the actual error?
github-actions commentedon Nov 9, 2026
This issue is idle after 60 days with no activity. It will be closed in 14 days if there is no further activity.
thomastvedt commentedon Nov 10, 2026
Cornelius Roemer (@corneliusroemer) fyi you can now opt-out of the fallback to a stable version setting
latest-fallback=false, see #303.I'm still of the opinion that hard-coding a fallback version is not the best design, and that the action should simply fail and not magically fallback to another version. But at least we can opt-out of the behaviour now :)