Repository navigation
feat: verify Helm downloads and support fallback mirrors - #315
Merged
Suneha Bose (bosesuneha) merged 5 commits intoNov 9, 2026
Merged
Suneha Bose (bosesuneha) merged 5 commits into
Suneha Bose (bosesuneha) merged 5 commits into
Conversation
David Gamero (davidgamero)
force-pushed
the
verify-downloads-and-fallback
branch
from
November 5, 2026 17:37
9cee81b to
a7f13d2
Compare
Suneha Bose (bosesuneha)
previously approved these changes
Nov 6, 2026
Suneha Bose (bosesuneha)
left a comment
Member
There was a problem hiding this comment.
Documenting that this changes v5 behavior: fresh downloads require matching .sha256 files. Archive-only custom mirrors must add them.
Collaborator
Author
thanks for catching that. we can start with using the checksum when available without making this a breaking change for custom mirrors since they may not have sums. adding a policy option with default |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autopolicyrequired,if-available, anddisabledchecksum policies for explicit controldownloadBaseURLFallbackmirror for version resolution, download, and verification failuresChecksum behavior
checksum-policydefaults toauto:autorequiredif-availabledisabledA checksum is considered missing only when its request returns HTTP 404 or 410. Timeouts, server errors, and other unexpected failures still fail closed. Selecting
disabledemits a warning.The same policy applies independently to primary and fallback downloads. Existing tool-cache entries continue to be reused without downloading or re-verifying the archive.
Checksums come from the same base URL as their archive. Verification detects corruption or incomplete mirror synchronization, but it does not protect against a mirror compromised together with its checksum files.
Validation
npm test(70 passing)npm run typechecknpm run format-checknpm run buildgit diff --checkactionlintstill reports the repository's existing missinglib/index.jssource-tree warning and deprecated integration-test token input; neither is introduced by this change.