Repository navigation
Fix incomplete-output fixture (true truncated value, drop ignore) - #13
Merged
Merged
Conversation
The ignored test used version||0x00||0x01 which Core treats as witness marker and parses as Ok(empty tx). Build a real input then only 7 value bytes so deserialize hits InsufficientBytes; drop #[ignore].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_transaction_incomplete_outputwas ignored claiming truncated output values are accepted, but the fixture was Core empty-vin + flag=1 (version||0x00||0x01||…), so parse returnedOkempty tx — not a truncated output.output_count=1, then only 7 value bytes; expectis_err()/ InsufficientBytes.#[ignore]. Does not change empty-vin+flag semantics elsewhere. Does not bump PARTIAL_BASELINE.Test plan
cargo fmt/cargo fmt --checkCARGO_INCREMENTAL=0 cargo check(with path patch aside → crates.io)CARGO_INCREMENTAL=0 RUST_BACKTRACE=1 cargo test --test engineering_suite test_transaction_incomplete_output(passes without--ignored)