Repository navigation
Fix taproot invalid key aggregation fixture and un-ignore test - #14
Merged
Merged
Conversation
The engineering suite used [0x79u8;32], which is not a valid x-only pubkey and fails with Invalid taproot tweak rather than testing wrong output-key rejection. Mirror the generator x from the unit test and drop the ignore that incorrectly blamed a secp256k1 backend mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_taproot_invalid_key_aggregationusedinternal_pubkey = [0x79u8; 32], which is not a valid x-only pubkey. That causedInvalid taproot tweak(not a secp256k1 backend mismatch), so the#[ignore]blame was wrong.src/taproot.rs::test_validate_taproot_key_aggregation_invalid/ the valid aggregation engineering test.#[ignore]and updated the comment accordingly.Test plan
cargo fmt --checkCARGO_INCREMENTAL=0 cargo check --features production(path patch aside)cargo test --test engineering_suite engineering::taproot_integration_tests::test_taproot_invalid_key_aggregation --features production(no--ignored) → ok