Repository navigation
Fix mixed SegWit/Taproot block fixture and un-ignore test - #16
Merged
Merged
Conversation
P2WPKH scriptPubKey was only OP_0 + PUSH_20 (2 bytes); is_segwit_transaction needs the full 20-byte program (22 bytes total). Mirror src/segwit.rs and drop the ignore that incorrectly claimed pending merkle/witness work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_mixed_block_segwit_and_taprootfailedis_segwit_transactionbecause the SegWit outputscript_pubkeywas onlyOP_0, PUSH_20_BYTES(2 bytes).OP_0+ push-20 + a 20-byte program (mirrored fromsrc/segwit.rs::test_is_segwit_transaction).#[ignore]and rewrote the comment — this test never connects a block, so the “pending witness/merkle” claim was wrong; no merkle/witness-commitment work invented.Test plan
cargo fmt/cargo fmt --checkCARGO_INCREMENTAL=0 cargo check(path-patch aside during CI-shaped run, restored after)cargo test --test engineering_suite engineering::bip_interaction_tests::test_mixed_block_segwit_and_taproot -- --exact(passes without--ignored)Stays completely off PR #15 /
fix/bip113-mtp-cltv-validation-logic. No PARTIAL_BASELINE bump, no merge/publish.