Repository navigation
Fix orphaned taproot_more_tests P2TR fixture (wire + PUSH_32) - #17
Merged
Merged
Conversation
BIP341 P2TR is OP_1 PUSH_32 <32-byte key> (34 bytes); the orphaned unit fixture omitted PUSH_32. Wire mod taproot_more_tests in unit/mod.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/taproot_more_tests.rswas orphaned (not intests/unit/mod.rs) and built P2TR as 33 bytes (OP_1+ 32-byte key), omitting BIP341PUSH_32.mod taproot_more_tests;and mirror the 34-byte fixture used bytaproot_integration_tests/taproot_suite(TAPROOT_SCRIPT_PREFIX,PUSH_32_BYTES, key).Test plan
cargo fmt/cargo fmt --checkCARGO_INCREMENTAL=0 cargo check(path patch aside → crates.io; restored after)cargo test --test unit_suite unit::taproot_more_tests::test_validate_taproot_script_and_extract_key -- --exact→ ok