Skip to content

Fix orphaned script_more_tests eval_script signature and wire module - #18

Merged
secsovereign merged 1 commit into
mainfrom
fix/script-more-tests-eval-script-sig
Sep 21, 2026
Merged

secsovereign merged 1 commit into
mainfrom
fix/script-more-tests-eval-script-sig

Conversation

@secsovereign

Copy link
Copy Markdown
Member

Summary

  • tests/unit/script_more_tests.rs was orphaned (not in tests/unit/mod.rs) and called the old 3-arg eval_script.
  • Wire mod script_more_tests; and update call sites to eval_script(&script, &mut stack, 0, SigVersion::Base).
  • Align fixtures/assertions with current consensus: op-limit uses OP_NOP (non-push opcodes count; OP_1 does not); stack overflow / large-script cases expect Err (or Ok(false)).
  • Does not pull other orphaned unit modules into this PR. No PARTIAL_BASELINE bump, no merge/publish.

Test plan

  • cargo fmt / cargo fmt --check
  • CARGO_INCREMENTAL=0 cargo check (path patch aside → crates.io; restored after)
  • cargo test --test unit_suite unit::script_more_tests:: → 3 passed (op-limit / stack-overflow / large-scripts)

Wire mod script_more_tests; use 4-arg eval_script with SigVersion::Base.
OP_NOP for op-limit (pushes do not count); assert Err on stack/op limits.
@secsovereign
secsovereign merged commit fb81762 into main Sep 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant