Repository navigation
Fix orphaned mempool_rbf_tests: wire module and live APIs - #19
Merged
Merged
Conversation
Wire mod mempool_rbf_tests; pass UtxoSet to 4-arg replacement_checks; import Network; assert MempoolResult::Rejected for duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/mempool_rbf_tests.rswas orphaned (not intests/unit/mod.rs) and called the old 3-argreplacement_checks.mod mempool_rbf_tests;and update call sites toreplacement_checks(&rbf_tx, &non_rbf_tx, &utxo, &pool)(passUtxoSet).Network; align duplicate detection withMempoolResult::Rejected(seed mempool —accept_to_memory_pooldoes not mutate it).Test plan
cargo fmt/cargo fmt --checkCARGO_INCREMENTAL=0 cargo check(path patch aside → crates.io; restored after)cargo test --test unit_suite unit::mempool_rbf_tests::→ 2 passed (rbf sequence / duplicate detection)