Skip to content

Fix orphaned mempool_rbf_tests: wire module and live APIs - #19

Merged
secsovereign merged 1 commit into
mainfrom
fix/mempool-rbf-tests-wire-module
Sep 21, 2026
Merged

secsovereign merged 1 commit into
mainfrom
fix/mempool-rbf-tests-wire-module

Conversation

@secsovereign

Copy link
Copy Markdown
Member

Summary

  • tests/unit/mempool_rbf_tests.rs was orphaned (not in tests/unit/mod.rs) and called the old 3-arg replacement_checks.
  • Wire mod mempool_rbf_tests; and update call sites to replacement_checks(&rbf_tx, &non_rbf_tx, &utxo, &pool) (pass UtxoSet).
  • Import Network; align duplicate detection with MempoolResult::Rejected (seed mempool — accept_to_memory_pool does not mutate it).
  • Does not pull other orphaned unit modules into this PR. No PARTIAL_BASELINE bump, no merge/publish.

Test plan

  • cargo fmt / cargo fmt --check
  • CARGO_INCREMENTAL=0 cargo check (path patch aside → crates.io; restored after)
  • cargo test --test unit_suite unit::mempool_rbf_tests:: → 2 passed (rbf sequence / duplicate detection)

Wire mod mempool_rbf_tests; pass UtxoSet to 4-arg replacement_checks;
import Network; assert MempoolResult::Rejected for duplicates.
@secsovereign
secsovereign merged commit f6554ff into main Sep 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant