02 encabezado y metadatos - #20
Conversation
…cabezado-y-metadatos
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4978cf595
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| padding: 8px 0px 16px 0px; | ||
| } | ||
| .title-container { | ||
| width: 591px; |
There was a problem hiding this comment.
Let the header width shrink on narrow panels
When the workspace switches to one column at max-width: 900px, the problem panel can be much narrower than 591px (for example, a 390px mobile viewport minus the panel padding). This fixed title width forces horizontal scrolling even for short challenge titles, whereas the previous inline <h1> could shrink with the panel. Use a fluid width such as width: 100%/max-width or remove the fixed width so the challenge header remains responsive.
Useful? React with 👍 / 👎.
| if (value >= 1_000) { | ||
| return `${(value / 1_000).toFixed(1)}K`; |
There was a problem hiding this comment.
Avoid formatting near-million counts as 1000.0K
For counts between 999,950 and 999,999, this branch runs before the million threshold but toFixed(1) rounds the displayed value up to 1000.0K. Because one more count renders as 1.0M, users see an inconsistent and misleading abbreviation at the boundary; choose the suffix after rounding or promote rounded 1000.0K values to the M format.
Useful? React with 👍 / 👎.
| } | ||
| .title-container { | ||
| width: 591px; | ||
| height: 32px; |
There was a problem hiding this comment.
Let long titles grow vertically
When a challenge has a title long enough to wrap, this fixed 32px container height still reserves only one line before the metadata row, so the second line of the <h1> overflows into or overlaps the meta controls. Challenge titles are user/content data and can be longer than the current fixture; let the title container use auto height instead of pinning it to a single line.
Useful? React with 👍 / 👎.
Descripción
En este PR se implementa el encabezado del reto (
challenge-header) para el workspace de desafíos.Cambios realizados
challenge-header.ProblemMetapara modelar los metadatos del problema.ChallengeProblemDtoconProblemMeta.formatCount.challenge-workspace.Closes #2