Repository navigation
fix(BAR-29): Reports panics as errors and compresses the installer with LZMA - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 What changed?
A panic in database work no longer fails silently: the query run, table page, import or AI assistant call it happened in ends with "BarSQL hit a bug", and a new panic hook writes the details to
crash.login the data folder. A few Postgres and MySQL reads that panicked on unexpected server values now return an error instead. The Windows installer is compressed with LZMA, which takes it from 23,732 KB to 15,714 KB (−34%). The version goes to 1.2.3.🧩 Type of change
🧪 Tested
📖 Docs
📌 Notes
panic = "abort"would save another 18 MB on disk, but any panic in database work would close the whole app.state::spawnshow the bug as an error toast. The results pane keeps the panic message as the error's detail.crash.logappends each panic with its time and starts over past 1 MB. A panic in UI code still closes the app on Windows and macOS, and its log entry is followed by a second "cannot unwind" entry.crash.logbacktraces are bare addresses, because the release exe is stripped and no PDB ships. The panic message and the file and line it came from are still there.