Repository navigation
chore(BAR-30): Splits the macOS zips by architecture and compresses the packages harder - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 What changed?
Makes the release downloads about 70 MB (15%) smaller through packaging alone; the build profile doesn't change. Each macOS zip now holds a single architecture, because the updater only ever downloads the zip for its own chip, and the dmg, rpm, Arch package and Windows installer compress harder. The landing page leads with the universal dmg so an Intel Mac can't end up with the Apple Silicon zip, and an Intel build running under Rosetta now updates to the Apple Silicon one.
🧩 Type of change
🧪 Tested
Checked locally:
installer.nsi(16.14 → 15.71 MB, and 7-Zip tests it clean), rancargo clippy -p barsql-app --all-targets --features e2e -- -D warningsand the 23 updater tests, and viewed the landing page in a browserbash -nandshellcheckon both packaging scripts, did a dry run ofpackage-macos.shwith stubbed macOS tools (each zip holds one architecture in a singleBarSQL.app, and the dmg holds both, made with-format ULMO), and ran the newCOMPRESSZSTthe way makepkg runs it (32 MiB window, decompresses)📖 Docs
📌 Notes
Expected sizes are the v1.2.3 assets scaled by the compression ratios measured locally on the release binary. The first Release run gives the real ones.
BarSQL-darwin-arm64.zipBarSQL-darwin-amd64.zipBarSQL-macos-universal.dmgBarSQL.pkg.tar.zstBarSQL.rpmBarSQL-amd64-installer.exe.zip, gzip.tar.gz) are unchanged, so released versions keep updating. Every rpm that read the zstd payload can read xz. Arch builds its own packages withzstd --ultra -20. ULMO dmgs open on macOS 10.15 and later, and BarSQL already needs macOS 12.update.rsonly compiles on macOS, and PR CI only builds Linux, so run Actions → Tests → Run workflow on this branch.