Repository navigation
docs: align song/track/recording wording with domain glossary - #311
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
It is a single comment-only wording change that correctly aligns with the domain glossary and has no functional, API, or changelog impact.
No open issues 🎉
What changed in this PR
This PR makes a wording-only documentation change to the module-header comment in the genre-tree library API barrel. It aligns the description of "reference" scope tracks with the shared domain glossary, clarifying that these tracks are songs keyed on a representative MusicBrainz recording id, rather than being MusicBrainz recordings themselves. This improves conceptual clarity without touching any identifiers, strings, or runtime behavior.
Changes:
- Reworded the "reference" tracks comment to say "tracks are songs (keyed on a representative MusicBrainz recording id)" instead of "tracks are MusicBrainz recordings".
| File | Description |
|---|---|
| packages/app-kit/src/genre-tree/api/library/index.ts | Updated a module-header comment to align track/song/recording terminology with the domain glossary; no code behavior changes. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording-only change (no identifiers or strings). Aligns docs/comments with the shared glossary: Track = generic supertype, Song = deduplicated catalog entry, Recording = MusicBrainz entity/ID only. Glossary: claude-config
CONVENTIONS.md, section "Domain glossary".🤖 Generated with Claude Code