Skip to content

feat!: inject the track noun via TrackNounProvider - #313

Merged
Andreas-Garcia merged 3 commits into
developfrom
feature/track-noun-provider
Oct 26, 2026
Merged

Andreas-Garcia merged 3 commits into
developfrom
feature/track-noun-provider

Conversation

@Andreas-Garcia

Copy link
Copy Markdown
Member

Summary

  • Add TrackNounProvider / useTrackNoun() (throws without provider) and a capitalize helper, exported as @behindthemusictree/app-kit/track-noun.
  • Replace hardcoded "track(s)" strings in TrackListSidebar, GenreDetailExtras, GenrePlaylistTracks, TrackUploadPopup.
  • Pass itemCountLabel to genre-tree-view (bumped to 3.0.0) from the three tree components.
  • Part of the song/track/recording wording unification (Phase 2). Needs a major release (14.0.0) afterwards.

Test plan

  • pnpm lint, pnpm build
  • vitest per package (app-kit 488, app-kit-ui 261); new tests for the hook (incl. throw without provider) and for the sidebar using an injected noun
  • coverage run not executed locally (disk full); CI covers it

🤖 Generated with Claude Code

Hardcoded "track(s)" UI strings now come from useTrackNoun(), and the tree
components pass genre-tree-view 3.0.0 its required itemCountLabel.

BREAKING CHANGE: components throw unless wrapped in TrackNounProvider.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Andreas-Garcia
Andreas-Garcia merged commit a6232c0 into develop Oct 26, 2026
2 of 3 checks passed
@Andreas-Garcia
Andreas-Garcia deleted the feature/track-noun-provider branch October 26, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants