Skip to content

fix(run-coolify-oneshot): quote args so the command survives ssh #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andreas-Garcia merged 1 commit into from
Oct 27, 2026
Merged

fix(run-coolify-oneshot): quote args so the command survives ssh #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/run-coolify-oneshot/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@ runs:
run: |
# The script is piped over stdin, so the remote shell's own stdin is the script itself: every
# command that could read stdin gets </dev/null.
# ssh joins its arguments with spaces and the remote shell re-splits them, so each one is shell-quoted.
remote_args=$(printf ' %q' "$APP_NAME" "$COOLIFY_ENVIRONMENT" "$IMAGE" "$TIMEOUT_MINUTES" "$RUN_ID" "$COMMAND")
ssh -o StrictHostKeyChecking=accept-new -o ServerAliveInterval=30 -o ServerAliveCountMax=10 \
"${SERVER_DEPLOY_USERNAME}@${SERVER_HOST}" \
bash -s -- "$APP_NAME" "$COOLIFY_ENVIRONMENT" "$IMAGE" "$TIMEOUT_MINUTES" "$RUN_ID" "$COMMAND" <<'REMOTE'
"bash -s --${remote_args}" <<'REMOTE'
set -euo pipefail
app=$1 env_name=$2 image=$3 timeout_minutes=$4 run_id=$5 command=$6
name_prefix="${app}-oneshot-${env_name}"
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ All contributors (including maintainers) should update `CHANGELOG.md` when creat

## [Unreleased]

### Fixed

- **`run-coolify-oneshot` dropped the command's arguments**: the remote shell re-split the command, so `python3 manage.py migrate --no-input` ran as bare `python3` and exited 0 without migrating; every argument is now shell-quoted before it crosses ssh

## [4.5.0] - 2026-10-27


Expand Down
Loading