Repository navigation
feat(slack): durable-host acknowledgement reaction on SlackHost - #27
Merged
Merged
Conversation
Co-Authored-By: Ishaan Jaffer <155045088+ishaan-berri@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Slack socket transport adds 👀 (
ack_emoji="eyes") before it dispatches a message. Durable hosts that only useSlackHost(e.g. Moyai's signed HTTP inbox) never got that, so each host had to hand-rollreactions.add. This PR moves the ack intoSlackHost, using the samerequest(api_method, payload)callback convention asupload_slack_files:Semantics:
_ack. It returnsTrueonokor onalready_reacted(replays).Falsewhen disabled, on a Slack error, on timeout, or when the callback raises anyException.CancelledErrorpropagates.ValueErrorbefore the callback runs.Core:
host::ack_request,host::ack_acceptedandSlackHost::acknowledgementare now the single payload source.socket.rsand the Python transport_ackboth use them, with no behavior change.Consumer: BerriAI/moyai#547
Link to Devin session: https://app.devin.ai/sessions/3d913080cfd147d1a3a4fd6db2988d5b
Open in Devin Desktop: https://app.devin.ai/desktop/session/3d913080cfd147d1a3a4fd6db2988d5b?variant=devin
Requested by: @ishaan-berri