Skip to content

Add source filtering to Node-RED layout trigger - #13

Merged
mrinc merged 1 commit into
masterfrom
fix/nodered-layout-source-filter
Sep 15, 2026
Merged

mrinc merged 1 commit into
masterfrom
fix/nodered-layout-source-filter

Conversation

@bcbetterninja

Copy link
Copy Markdown
Contributor

Summary

Tenant layout switches can emit both server and kiosk events, but the Layout Changed trigger previously discarded their source. Preserve msg.payload.source and add a Source dropdown with All (not set), Server, and Kiosk options so flows can choose which events to receive.

Existing flows continue receiving all sources. Missing sources are emitted as null and only pass when the filter is unset. Both event producers remain active. Includes editor help and documentation.

Validation

  • Focused Node-RED event tests: 2 passed, covering source preservation/filtering, legacy defaults, missing/unknown sources, tenant/display scope, authentication, and subscriber fan-out.
  • Editor script/default/dropdown checks passed.
  • JavaScript syntax and git diff --check passed.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ded8b6c9-12d3-44b5-a38a-00a103ac02ea


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mrinc
mrinc merged commit 809e7d7 into master Sep 15, 2026
9 checks passed
@mrinc
mrinc deleted the fix/nodered-layout-source-filter branch September 15, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants