Automatically recover stale mail IDs and retry once - #23
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1f65e0a18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| catch (HttpRequestException error) when (error.StatusCode == HttpStatusCode.NotFound) { } | ||
| if (verified is null) | ||
| { | ||
| var results = await provider.SearchMessagesAsync(account, mailbox, cached.Subject, 100, token); |
There was a problem hiding this comment.
For a subjectless Microsoft 365 message whose saved provider ID now returns 404, this passes an empty query to Microsoft365MailProvider.SearchMessagesAsync, which immediately returns an empty result for whitespace queries. Consequently both automatic and manual recovery always report no unique match and leave the action paused even though a usable Internet Message-ID is cached. Use a nonempty identity-based query or otherwise support subjectless messages.
Useful? React with 👍 / 👎.
| if (verified.ProviderId != current.ProviderId) | ||
| await DeleteMessageAsync(connection, transaction, current.MailboxId, current.ProviderId!, token).ConfigureAwait(false); |
There was a problem hiding this comment.
When a standalone UpdateState action is recovered to a new provider ID, this deletes the old cached row but records no durable tombstone or alias. The repaired state action is deleted by CompleteMessageStateAsync, after which a delayed source-folder page containing the old ID passes through ApplySyncPageAsync and is blindly upserted, leaving both the valid and obsolete copies visible and allowing subsequent actions to target the dead ID again. Preserve enough recovery metadata to reject stale sync records for the replaced ID.
Useful? React with 👍 / 👎.
2 participants
A queued move can retain a server ID that changed when another client moved the message. Repeating the old ID never succeeds. Missing-object failures now automatically attempt identity recovery once, including existing paused actions, and retry a verified repair in the same Busy-processing pass.
recover_mail_actionMCP support.Validation: Release build with zero warnings/errors and 522 passing tests. Regressions cover automatic old-ID/new-ID execution without a user command, failure pause, restart persistence, exact versus ambiguous matches, concurrent queue edits, dependent moves, destination confirmation, cancellation provenance, stale source sync and MCP permissions/discovery. Native Busy preview checked with fictional data in light/dark modes. No live mailbox content or queued action was changed during development.