Skip to content

feat: add secure Provider Guard for session visibility - #1517

Closed
k9ight000 wants to merge 1 commit into
BigPizzaV3:mainfrom
k9ight000:codex/provider-guard-script-market
Closed

k9ight000 wants to merge 1 commit into
BigPizzaV3:mainfrom
k9ight000:codex/provider-guard-script-market

Conversation

@k9ight000

Copy link
Copy Markdown

Summary

  • add a read-only Provider Guard bridge status endpoint
  • add native-manager-only backup and repair flow for stable provider id \custom`n- inspect SQLite provider buckets without returning credentials or private endpoint details
  • harden script marketplace downloads with HTTPS/loopback restrictions, size limits, and mandatory SHA-256 verification
  • explicitly keep repair unavailable to injected marketplace scripts

Safety

  • marketplace JavaScript can only inspect status and open the native manager
  • repair requires a native manager confirmation
  • config is backed up and rechecked before atomic update
  • provider sync keeps its existing session/SQLite backup and rollback behavior
  • no API keys, tokens, full URLs, or config contents are returned to injected scripts

Verification

  • frontend unit tests: 14 passed
  • marketplace JS syntax and manifest hash verified
  • full Rust/TypeScript/build verification delegated to GitHub Actions because the local machine has no Rust toolchain or installed frontend dependencies

@BigPizzaV3

Copy link
Copy Markdown
Owner

Codex++ maintainer review note

当前 main 下这个 PR 仍存在 merge conflict,暂时不能合并。请先 rebase 到最新 main 并解决冲突;更新后我们会重新跑针对性测试再复审。

This PR currently conflicts with main, so it is not mergeable yet. Please rebase onto the latest main and resolve the conflicts, then we can review and test it again.

@BigPizzaV3

Copy link
Copy Markdown
Owner

感谢贡献。该 PR 当前仍与 main 存在合并冲突,且改动范围较大,无法直接复审合并。为避免长期挂起,现关闭此 PR;Provider Guard 与脚本市场安全能力如需继续,请基于最新 main 重新整理后提交。

@BigPizzaV3

Copy link
Copy Markdown
Owner

已按维护说明关闭:当前存在合并冲突,后续请基于最新 main 重提。

@BigPizzaV3 BigPizzaV3 closed this Aug 25, 2026
@BigPizzaV3 BigPizzaV3 reopened this Aug 25, 2026
@BigPizzaV3

Copy link
Copy Markdown
Owner

状态更正:此 PR 按维护要求保持开启。请基于 7385664 rebase,并把 Provider Guard 的只读检测/备份修复与 script market 下载加固拆开,避免与 #603 重复;Guard 需补未授权路由、备份路径校验、部分数据库失败、dry-run 和不返回 endpoint/key 等隐私字段测试。

@k9ight000
k9ight000 force-pushed the codex/provider-guard-script-market branch from 9170fb0 to 30fc145 Compare August 30, 2026 11:26
@BigPizzaV3

Copy link
Copy Markdown
Owner

请按维护意见拆分 Provider Guard 与脚本市场下载校验,避免与 #603 重复。Provider Guard 需补未授权路由、备份路径校验、部分数据库失败、dry-run 以及不返回 endpoint/key 的隐私测试;拆分后分别 rebase 并跑 CI。

@BigPizzaV3 BigPizzaV3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该 PR 同时包含 Provider Guard、脚本市场安全加固和大篇幅架构文档,且当前分支与 main 冲突、页面无 CI 结果。请拆分或至少基于最新 main rebase,补跑三平台 CI;安全加固需确认空 sha256 兼容、校验失败不落盘,并避免向注入脚本暴露凭据。

@BigPizzaV3

Copy link
Copy Markdown
Owner

关停说明:\n\n本 PR 自 9/04 审查意见后无实质更新(当前 head 仍与 main 冲突,卡在 Cargo 文件;页面无三平台 CI 结果)。更关键的是,它与你已经交给我维护方处理的同类能力重叠:#603(Tauri runtime guard + market-script sha256 校验,已按拆分思路处理)已在主线落下同样主题;代码库当前也有独立的 Provider Guard / 脚本市场安全件。\n\n建议拆分后重提,每块针对性强、可独立审视:\n\n1. Provider Guard 只读状态:只读检测 + 备份修复 + 不返回凭据/endpoint/key 的隐私测试,补未授权路由、备份路径校验、部分数据库失败、dry-run 用例。\n2. 脚本市场下载加固:HTTPS/loopback 限制、大小上限、SHA-256 强制校验(含空 sha256 兼容与校验失败不落盘)。\n3. 删掉大篇幅架构文档/设计说明,放 issue 讨论即可,别混进 diff。\n\n请基于最新 main 分别 rebase,解决冲突后跑三平台 CI 再提。本分支关闭,后续按拆分方向另开新 PR。

@BigPizzaV3 BigPizzaV3 closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants