fix: align Dream Skin runtime with Codex 26.825 - #1712
Conversation
|
追加修复:Codex 26.727 将主内容节点的 main-surface class 改为 CSS Modules 类名,导致 DreamSkin 图片资源虽已生成 Blob URL 但没有匹配到背景 CSS。新增 renderer 兼容层,在不改动 Codex 原生 class 的前提下恢复 main-surface 选择器契约,并在 cleanup 时回收兼容标记。已用实际 Codex CDP 验证 ::before background-image 包含 Blob 图片 URL;npm test 36/36、cdp_bridge 94/94 通过。Commit: 7f5b57d |
|
追加修复:Codex 26.727 将原生顶部渐隐层改为 CSS Modules 类名 _MainContentTopFade_zbk1f_251,旧版 .app-shell-main-content-top-fade 规则无法匹配,导致主内容上方出现黑色渐变条。DreamSkin CSS 现同时隐藏旧 class 和 [class*="MainContentTopFade"]。已通过实际 CDP 验证该元素 display:none;commit 9d5f916。 |
3fd9929 to
62e278f
Compare
|
维护者审查:Dream Skin 与新版 Codex DOM/主题契约同步有价值,但当前 PR 改动 23 个文件、约 5,000 行,并直接携带两平台上游 runtime 资产;分支现已与 |
62e278f to
0381708
Compare
|
@BigPizzaV3 已按审查意见重新整理,麻烦再看一下。
本地验证:
三平台 CI 也已完成:Windows release/NSIS、macOS arm64 DMG、macOS x64 DMG 全部通过: 当前 head: |
|
当前 PR 虽然无冲突,但基于旧 main 且主仓没有可核验的最新 checks。请 rebase 到当前 main,重新触发 Windows/macOS 三平台 CI,并复核新版 Codex 26.825 下 Dream Skin 资产和首页 Composer 行为。 |
80371aa to
1fbf91a
Compare
|
@BigPizzaV3 已按 2026-09-02 的审查回复完成更新,麻烦再审。
本地验证:
三平台 CI 已在新 head 主仓也已为同一 head 生成 PR run,但目前处于外部贡献分支的 实机复核补充:本机当前实际 Codex Desktop 已是 |
1fbf91a to
8d6c86a
Compare
|
@BigPizzaV3 已按 9 月 4 日的 review 更新。先明确一下缺少 checks 的原因:代码此前已推送,旧主仓运行 本次已完成:
请维护者批准这次主仓运行,才能获得本仓可见 checks: 该运行对应新 head 同一 head 的新一轮 fork 三平台 artifact CI 现已全部通过:
以上仍是 fork 的结果;主仓 checks 仍需批准上面对应的 PR run 后实际运行。 |
Review Status (2026-09-05)
main48d43158688f5096c7059c690f8cd1daab340681.8d6c86a1763d8c6022339699eafc6a5197408bec.action_requiredfor this exact head. No upstream checks have passed yet; this is not a missing push.Summary
data-dream-skin,data-ds-part, and current composer selectors.Scope
The PR still changes 11 files: four upstream assets, two narrow Codex++ runtime files, and focused regression/hash tests. It does not include the earlier palette/editor expansion, theme schema, launcher compatibility, workflow changes, or unrelated version/documentation changes.
Local Verification (2026-09-05)
dream_skin: 19 passed.dream_skin_runtime: 13 passed, 1 ignored (the separate live-apply integration test).upstream_theme_assets: 2 passed.cdp_bridge: 153 passed.git diff --check: passed.cargo build --workspace: passed.app_paths_resolves_portable_current_link_to_directory_versionfiltered out: this non-elevated Windows session cannot create its symlink (OS error 1314). This is not an unqualified localcargo test --workspacepass.The first local bridge run hit three unrelated Stepwise source-string assertions because an existing Windows checkout had CRLF in files marked
eol=lf. Normalizing those working-copy files to the already-committed LF bytes fixed all three; no Stepwise source changes are included.For the broader local run,
NO_PROXY=127.0.0.1,localhost,::1was set only in the test process so loopback network tests did not go through the machine's proxy. The VLM connection-error test passed with that setting. No persistent environment or security settings were changed.Home / New-Conversation Regression
Live Windows smoke test on Codex Desktop
26.901.5280.0, with the installedr24-home-composer-roundedDream Skin runtime:This verifies opening a new-conversation page and editing its input. It does not claim a new model request completed or that every marketplace theme in #2082/#2064 has been verified. The live smoke used the already-installed matching runtime assets, not newly installed binaries from this rebase.
Asset Hashes
Both platforms retain identical checked upstream asset bytes:
renderer-inject.js:1F1E408F8B89BEF6B83DE0A5EE047BFB1F8DFD0165628398D520B8897083FFD7dream-skin.css:EF6A690AFFF79493EA2414C1DFD7837A2527AC3D2387BE24A0960657F55B182CFresh CI Results
cargo test --workspace, release binaries, NSIS installer, and uploadsArtifacts: Windows binaries, Windows installer, macOS arm64 DMG, and macOS x64 DMG. No workflow changes or approval bypasses were added.