Skip to content

fix: align Dream Skin runtime with Codex 26.825 - #1712

Open
chenzhaoxuan0 wants to merge 6 commits into
BigPizzaV3:mainfrom
chenzhaoxuan0:codex/upgrade-dream-skin-runtime
Open

fix: align Dream Skin runtime with Codex 26.825#1712
chenzhaoxuan0 wants to merge 6 commits into
BigPizzaV3:mainfrom
chenzhaoxuan0:codex/upgrade-dream-skin-runtime

Conversation

@chenzhaoxuan0

@chenzhaoxuan0 chenzhaoxuan0 commented Jul 30, 2026

Copy link
Copy Markdown

Review Status (2026-09-05)

  • Rebased onto upstream main 48d43158688f5096c7059c690f8cd1daab340681.
  • Current pushed head: 8d6c86a1763d8c6022339699eafc6a5197408bec.
  • Upstream PR CI requires maintainer approval: PR build artifacts run 33966141258 is action_required for this exact head. No upstream checks have passed yet; this is not a missing push.
  • Fresh fork CI passed: three-platform artifact run 33966153621 completed successfully for this exact head. Windows artifacts, macOS arm64 DMG, and macOS x64 DMG all passed; four artifact groups were uploaded. These results are separate from upstream PR checks.

Summary

  • Sync the bundled Dream Skin Windows/macOS renderer and CSS assets needed for the Codex 26.825+ selector/surface contract.
  • Preserve the upstream runtime observer/timer after Codex++ adopts it. Update diagnostics for adopted stylesheets, data-dream-skin, data-ds-part, and current composer selectors.
  • Align the Home composer surface and preserve four rounded corners on Windows, leaving thread composers unchanged.
  • Maintain byte-exact SHA-256 guards for all four synchronized upstream assets.
  • Add a regression matrix checking that an adopted runtime passes with a visible composer and fails with a hidden composer on both Home and thread routes.

Scope

The PR still changes 11 files: four upstream assets, two narrow Codex++ runtime files, and focused regression/hash tests. It does not include the earlier palette/editor expansion, theme schema, launcher compatibility, workflow changes, or unrelated version/documentation changes.

Local Verification (2026-09-05)

  • Manager Node tests: 158 passed.
  • TypeScript check and Vite build: passed.
  • dream_skin: 19 passed.
  • dream_skin_runtime: 13 passed, 1 ignored (the separate live-apply integration test).
  • upstream_theme_assets: 2 passed.
  • cdp_bridge: 153 passed.
  • git diff --check: passed.
  • cargo build --workspace: passed.
  • Remaining workspace tests passed with only app_paths_resolves_portable_current_link_to_directory_version filtered out: this non-elevated Windows session cannot create its symlink (OS error 1314). This is not an unqualified local cargo test --workspace pass.

The first local bridge run hit three unrelated Stepwise source-string assertions because an existing Windows checkout had CRLF in files marked eol=lf. Normalizing those working-copy files to the already-committed LF bytes fixed all three; no Stepwise source changes are included.

For the broader local run, NO_PROXY=127.0.0.1,localhost,::1 was set only in the test process so loopback network tests did not go through the machine's proxy. The VLM connection-error test passed with that setting. No persistent environment or security settings were changed.

Home / New-Conversation Regression

Live Windows smoke test on Codex Desktop 26.901.5280.0, with the installed r24-home-composer-rounded Dream Skin runtime:

  1. Started from an existing task with an empty composer.
  2. Clicked the native "New conversation" sidebar button; the skin runtime changed from thread to Home scope.
  3. Confirmed the Home input was visible, inside the viewport, tagged as the composer, and using its adopted stylesheet.
  4. Focused the input, typed a test string, verified the exact text, and cleared it without sending.
  5. Confirmed 22px composer corners, no horizontal overflow, and no captured page errors.
  6. Returned to the original task and confirmed the thread composer was still visible and styled.

This verifies opening a new-conversation page and editing its input. It does not claim a new model request completed or that every marketplace theme in #2082/#2064 has been verified. The live smoke used the already-installed matching runtime assets, not newly installed binaries from this rebase.

Asset Hashes

Both platforms retain identical checked upstream asset bytes:

  • renderer-inject.js: 1F1E408F8B89BEF6B83DE0A5EE047BFB1F8DFD0165628398D520B8897083FFD7
  • dream-skin.css: EF6A690AFFF79493EA2414C1DFD7837A2527AC3D2387BE24A0960657F55B182C

Fresh CI Results

Job Result Duration
Windows artifacts Passed, including frontend tests, TypeScript, unfiltered cargo test --workspace, release binaries, NSIS installer, and uploads 14m39s
macOS DMG (arm64) Passed, including release build, bundle verification, and upload 5m30s
macOS DMG (x64) Passed, including release build, bundle verification, and upload 9m56s

Artifacts: Windows binaries, Windows installer, macOS arm64 DMG, and macOS x64 DMG. No workflow changes or approval bypasses were added.

@chenzhaoxuan0

Copy link
Copy Markdown
Author

追加修复:Codex 26.727 将主内容节点的 main-surface class 改为 CSS Modules 类名,导致 DreamSkin 图片资源虽已生成 Blob URL 但没有匹配到背景 CSS。新增 renderer 兼容层,在不改动 Codex 原生 class 的前提下恢复 main-surface 选择器契约,并在 cleanup 时回收兼容标记。已用实际 Codex CDP 验证 ::before background-image 包含 Blob 图片 URL;npm test 36/36、cdp_bridge 94/94 通过。Commit: 7f5b57d

@chenzhaoxuan0

Copy link
Copy Markdown
Author

追加修复:Codex 26.727 将原生顶部渐隐层改为 CSS Modules 类名 _MainContentTopFade_zbk1f_251,旧版 .app-shell-main-content-top-fade 规则无法匹配,导致主内容上方出现黑色渐变条。DreamSkin CSS 现同时隐藏旧 class 和 [class*="MainContentTopFade"]。已通过实际 CDP 验证该元素 display:none;commit 9d5f916

@chenzhaoxuan0
chenzhaoxuan0 force-pushed the codex/upgrade-dream-skin-runtime branch 2 times, most recently from 3fd9929 to 62e278f Compare August 25, 2026 12:10
@BigPizzaV3

Copy link
Copy Markdown
Owner

维护者审查:Dream Skin 与新版 Codex DOM/主题契约同步有价值,但当前 PR 改动 23 个文件、约 5,000 行,并直接携带两平台上游 runtime 资产;分支现已与 main 冲突,主线的 Dream Skin 与 renderer 也继续演进。请 rebase 最新 main,只保留当前仍缺失的主题字段/runtime 差异,重新生成并验证 upstream asset hash,跑 dream_skindream_skin_runtimeupstream_theme_assets、renderer 测试及三平台 CI。更新后再复审。

@chenzhaoxuan0
chenzhaoxuan0 force-pushed the codex/upgrade-dream-skin-runtime branch from 62e278f to 0381708 Compare August 30, 2026 03:47
@chenzhaoxuan0 chenzhaoxuan0 changed the title feat: align Dream Skin runtime and theme colors fix: align Dream Skin runtime with Codex 26.825 Aug 30, 2026
@chenzhaoxuan0

Copy link
Copy Markdown
Author

@BigPizzaV3 已按审查意见重新整理,麻烦再看一下。

  • 分支已基于当前 main716e8d0 重做,当前可直接合并,没有旧分支冲突。
  • 改动从原来的 23 个文件收敛到 11 个文件;已移除完整 Windows 色板/编辑器扩展、主题 schema、launcher 兼容、文档和版本等非必要改动。
  • 当前只保留 Dream Skin v1.5.16 在 Codex 26.825 下仍缺失的 Windows/macOS runtime 资产,以及 Codex++ 对 adopted stylesheet、data-dream-skindata-ds-part、新版 Composer/surface 的最小诊断适配和回归测试。
  • 修正了 Home utility bar 与 Composer surface 对齐,以及 Windows 首页 Composer 顶部直角问题;thread Composer 不受影响。
  • 已重新生成 byte-exact upstream asset hash。当前 renderer SHA-256 为 1F1E408F...FFD7,双端 CSS 为 EF6A690A...182Cupstream_theme_assets 已通过。

本地验证:

  • dream_skin: 19 passed
  • dream_skin_runtime: 12 passed / 1 live-CDP test ignored
  • upstream_theme_assets: 2 passed
  • cdp_bridge: 113 passed
  • Manager Node tests: 117 passed
  • TypeScript check、Vite build、cargo build --workspace 通过
  • Windows Codex 26.825 实机重启验证通过,用户已确认首页显示和圆角正常

三平台 CI 也已完成:Windows release/NSIS、macOS arm64 DMG、macOS x64 DMG 全部通过:
https://github.com/chenzhaoxuan0/CodexPlusPlus/actions/runs/33296481652

当前 head: 80371aa。PR 标题和说明也已按当前真实范围更新,申请重新 review。

@BigPizzaV3

Copy link
Copy Markdown
Owner

当前 PR 虽然无冲突,但基于旧 main 且主仓没有可核验的最新 checks。请 rebase 到当前 main,重新触发 Windows/macOS 三平台 CI,并复核新版 Codex 26.825 下 Dream Skin 资产和首页 Composer 行为。

@chenzhaoxuan0
chenzhaoxuan0 force-pushed the codex/upgrade-dream-skin-runtime branch from 80371aa to 1fbf91a Compare September 3, 2026 12:42
@chenzhaoxuan0

Copy link
Copy Markdown
Author

@BigPizzaV3 已按 2026-09-02 的审查回复完成更新,麻烦再审。

  • 已 rebase 到 2026-09-03 当前 mainf70ec61;PR 新 head:1fbf91a,当前仍为 MERGEABLE
  • 改动范围保持 11 个文件,没有重新引入已裁掉的非必要内容。
  • 已重新核对 Codex-Dream-Skin 两平台源资产,PR 中 Windows/macOS 文件均保持 byte-exact:
    • renderer-inject.js: 1F1E408F8B89BEF6B83DE0A5EE047BFB1F8DFD0165628398D520B8897083FFD7
    • dream-skin.css: EF6A690AFFF79493EA2414C1DFD7837A2527AC3D2387BE24A0960657F55B182C

本地验证:

  • Manager Node tests: 158 passed
  • dream_skin: 19 passed
  • dream_skin_runtime: 12 passed / 1 live-CDP test ignored
  • upstream_theme_assets: 2 passed
  • Dream Skin 相关 cdp_bridge: 4 passed
  • TypeScript check、Vite build、cargo build --workspace 通过
  • Dream Skin runtime 双端同步、Windows/macOS payload 检查及 renderer runtime test 通过

三平台 CI 已在新 head 1fbf91a 完整通过:Windows release/NSIS、macOS arm64 DMG、macOS x64 DMG 均成功,四组产物已上传:
https://github.com/chenzhaoxuan0/CodexPlusPlus/actions/runs/33756805644

主仓也已为同一 head 生成 PR run,但目前处于外部贡献分支的 action_required,需要维护者批准后才会把 checks 直接挂到 PR:
https://github.com/BigPizzaV3/CodexPlusPlus/actions/runs/33756749126

实机复核补充:本机当前实际 Codex Desktop 已是 26.901.1978.0(比 26.825 更新;CLI 0.144.6)。当前已安装的 r24-home-composer-rounded 构建持续正常使用;live CDP selector doctor 为 pass: true,adopted stylesheet 已挂载,主表面/侧栏/顶部渐隐/Composer/工具栏/thread surface/消息选择器均命中,当前任务页 Composer 为 22px 圆角且无横向溢出。首页 Composer 行为也已由用户实际使用确认正常。

@BigPizzaV3 BigPizzaV3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该 PR 声称已通过三平台 CI,但当前 PR 页面没有可见的本仓检查结果。由于它直接替换 Dream Skin 运行时资源,且关联 #2082/#2064,请基于最新 main 重新触发三平台 artifact CI,并补充首页输入框/新会话回归结果后再合并。

@chenzhaoxuan0
chenzhaoxuan0 force-pushed the codex/upgrade-dream-skin-runtime branch from 1fbf91a to 8d6c86a Compare September 5, 2026 12:28
@chenzhaoxuan0

chenzhaoxuan0 commented Sep 5, 2026

Copy link
Copy Markdown
Author

@BigPizzaV3 已按 9 月 4 日的 review 更新。先明确一下缺少 checks 的原因:代码此前已推送,旧主仓运行 33756749126action_required,不是代码没有推上去。9 月 3 日通过的三平台结果来自 fork,不能等同于主仓 PR checks。

本次已完成:

  • Rebase 到 2026-09-05 最新 main48d4315,新 head 8d6c86a1763d8c6022339699eafc6a5197408bec 已推送,仍可合并。
  • 范围仍为 11 个文件;仅追加首页/会话页 composer 可见性回归矩阵,四份 upstream runtime/CSS 的哈希保持不变。
  • 本地通过:Manager 158、dream_skin 19、dream_skin_runtime 13(另 1 个 live-apply 测试 ignored)、upstream_theme_assets 2、cdp_bridge 153,以及 TypeScript/Vite。
  • 补充全量本地验证:回环测试使用进程级 NO_PROXY 绕开本机代理;仅过滤一个因非提权 Windows 无法创建符号链接而报 OS 1314 的既有 launcher 测试后,其余 workspace 测试通过。因此不声称本地无过滤全量通过;未提权、未修改该测试。
  • 本机 Codex Desktop 26.901.5280.0、已安装的 r24-home-composer-rounded runtime 实测:点击原生“新对话”后首页输入框可见、可聚焦并输入;清空测试文字后返回原任务,会话页输入框仍正常。两页 adopted stylesheet 均在、圆角 22px、无横向溢出、未捕获 page error。测试未发送模型请求,因此不把它表述为新会话发消息端到端通过;也不声称覆盖所有市场主题。
  • 已重写 PR 正文,移除旧 80371aa / 716e8d0 及过时的 CI 表述,明确当前验证范围。

请维护者批准这次主仓运行,才能获得本仓可见 checks:
https://github.com/BigPizzaV3/CodexPlusPlus/actions/runs/33966141258

该运行对应新 head 8d6c86a,当前仍为 action_required。当前贡献者账号没有主仓 write/maintain 权限,无法自行批准,也没有更改 workflow 或绕过审批。

同一 head 的新一轮 fork 三平台 artifact CI 现已全部通过
https://github.com/chenzhaoxuan0/CodexPlusPlus/actions/runs/33966153621

  • Windows artifacts:14m39s,包含前端测试、TypeScript、无过滤 cargo test --workspace、release 编译和 NSIS 安装包。
  • macOS arm64 DMG:5m30s,编译、bundle 校验及上传通过。
  • macOS x64 DMG:9m56s,编译、bundle 校验及上传通过。
  • 四组 artifact 已上传且未过期。本地 cargo build --workspace 也已通过。

以上仍是 fork 的结果;主仓 checks 仍需批准上面对应的 PR run 后实际运行。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants