feat(skills): support shared ~/.agents/skills root - #2054
Closed
k9ight000 wants to merge 1 commit into
Closed
Conversation
Owner
|
请补充 Skill 根目录切换时的归属保护:出现 后会切换源目录,但现有 只按 ID 记录,旧私有 Skill 与同名共享 Skill 可能被误判为 managed,进而允许覆盖或归档。需要记录源根、迁移或冲突处理,并补跑 CI。 |
Owner
|
更正:请补充 Skill 根目录切换时的归属保护:出现 ~/.agents/skills 后会切换源目录,但现有 skills.json 只按 ID 记录,旧私有 Skill 与同名共享 Skill 可能被误判为 managed,进而允许覆盖或归档。需要记录源根、迁移或冲突处理,并补跑 CI。 |
Owner
|
请补充共享 ~/.agents/skills 根目录切换时的归属保护:现有 skills.json 只按 ID 记录,同名的旧私有 Skill 与共享 Skill 可能被误判为 managed,进而被覆盖或归档。请记录来源根目录并补同名冲突、切换根目录和启停回归测试,同时触发 CI。 |
BigPizzaV3
requested changes
Sep 4, 2026
BigPizzaV3
left a comment
Owner
There was a problem hiding this comment.
当前分支与 main 冲突,且改动同时涉及共享 skills 根目录、UI 状态和归档/回滚。请基于最新 main rebase,确认不会覆盖用户已有 ~/.agents/skills 内容,并补跑三平台 CI 与共享/本地 Skill 升级回滚测试;完成后再复审。
Owner
|
关闭理由:分支已与当前 main 冲突(mergeable=CONFLICTING),且自 8-30 我的审查意见(共享 skills 根的归属保护/迁移)后作者未再更新、未 rebase、未新增提交。若计划继续,请基于最新 main rebase 并处理同名 skill 冲突后重开。此关闭随时可重开。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.agents/skillsroot when it already exists while retaining the legacy Codex++ source as a fallback[[skills.config]]entries for shared-mode togglesVerification
cargo test -p codex-plus-core --lib(303 passed)npm run checknpm run vite:buildcargo clippy -p codex-plus-core -p codex-plus-manager --all-targetsgit diff --checkRelated to #1190.