Skip to content

fix(windows): re-resolve Codex Desktop path after updates (#2094, #2095) - #2097

Merged
BigPizzaV3 merged 3 commits into
BigPizzaV3:mainfrom
dongyu23:codex/fix-windows-codex-path-2094-2095
Sep 9, 2026
Merged

fix(windows): re-resolve Codex Desktop path after updates (#2094, #2095)#2097
BigPizzaV3 merged 3 commits into
BigPizzaV3:mainfrom
dongyu23:codex/fix-windows-codex-path-2094-2095

Conversation

@dongyu23

@dongyu23 dongyu23 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-resolve the current Codex Desktop installation after Windows Store/AppX updates.
  • Support both legacy OpenAI.Codex packages and the newer OpenAI.ChatGPT-Desktop package identity, including neutral_~_publisher MSIX full names.
  • Keep explicit --app-path, standalone Windows installs, and existing macOS bundle resolution behavior unchanged.
  • Refresh AppX package discovery on every resolution instead of reusing stale process-level package data.

Scope

This PR primarily targets Windows, which is the platform affected by the versioned WindowsApps installation paths reported in #2094 and #2095. macOS behavior is kept compatible and covered by existing regression tests. Codex++ currently does not ship a Linux Desktop target, so Linux Desktop discovery is intentionally outside this PR.

Issues

Closes #2094
Closes #2095

Testing

  • F:\\cargo\\bin\\cargo.exe +stable test -p codex-plus-core
  • Result: 308 passed, 0 failed.
  • Targeted launcher/path tests: 31 passed, 0 failed.

Additional coverage includes old and new AppX package identities, stale saved Store paths after an update, explicit path precedence, Codex++ manager path rejection, portable installs, and macOS bundles.

Notes

The existing unrelated unused import: std::io::Write warning remains unchanged.

@BigPizzaV3 BigPizzaV3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请先基于当前 main(包含已合并的 #2096)整理分支并重跑 CI。\n\n当前分支仍包含 #2096 的提交 77fc5de,会与已合并改动重复;请 drop 该重复提交后 rebase 到最新 main。\n\n另外请补充/确认 Windows AppX 查询失败、旧 Store 路径仍存在以及新旧宿主并存时的选择行为:自动解析应优先当前注册且版本最高的受支持包,查询失败时才回退已保存路径;显式用户指定的路径应保持原有覆盖语义。完成后请附 Windows 实机或等价测试结果,并重跑三平台 CI。

@dongyu23
dongyu23 force-pushed the codex/fix-windows-codex-path-2094-2095 branch from 699035d to b67b2f8 Compare September 4, 2026 11:35
@BigPizzaV3

BigPizzaV3 commented Sep 9, 2026

Copy link
Copy Markdown
Owner

复核:你 force-push 后,分支中仍包含 #2096 的重复提交 77fc5de(经核实 77fc5de 仍是 pr-2097 的祖先)。该 merge 提交 11179a0 已含在最新 main 里,请 drop 这个重复提交并 rebase 到最新 main(当前 07c3659),再重跑三平台 CI,并补齐 Windows AppX 查询失败回退、新旧宿主并存的选择行为测试。处理完我会立即复审。

@BigPizzaV3 BigPizzaV3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

作者已把重复 commit 77fc5de 移除,分支现为干净三提交(f4f9bae9 可合并入当前 main,0 冲突)。解除此前的阻塞。\n\n合并前请确认在最新 main 上通过 Windows artifacts / macOS DMG (arm64) / macOS DMG (x64) 三平台 CI;该修复针对 Windows 更新后 Codex 路径重解析,建议附一个验证 Codex 更新路径场景的用例。

@BigPizzaV3
BigPizzaV3 merged commit da29074 into BigPizzaV3:main Sep 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 重启 Codex++ Codex App directory not found [Bug]: codex更新后无法启动

2 participants