fix: replace stale model catalog on provider switch - #2122
Merged
BigPizzaV3 merged 1 commit intoSep 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_catalog_jsonwhen switching to a different provider profileProblem
When
config.tomlpoints to a catalog generated for another Codex++ profile,apply_model_catalog_to_configtreats the path like an external user-managed catalog. For custom Responses providers whose catalog already has the expected wire-format flags,copy_standard_responses_catalogreports no changes and the function returns without replacing the pointer. Codex then continues showing the previous provider's models after a provider switch and full restart.Fix
Treat paths under Codex++'s managed
model-catalogsdirectory as owned projections. If the existing managed path does not match the selected profile, remove the stale pointer and let the normal generation path create and select the current profile's catalog.Validation
apply_relay_profile_replaces_catalog_generated_for_another_profilegit diff --checkpasses