Extend lexer for SimplicityHL formatter - #372
Open
ikripaka wants to merge 13 commits into
Open
Conversation
ikripaka
force-pushed
the
feat/fmt-parser
branch
from
July 23, 2026 13:51
e71710c to
3e6427e
Compare
* edit logic of lexer to include other characters as well for formatting * add FmtTokens, which stores comments, newlines and whitespaces data * mark Token as non-exhaustive * modify parser to ignore comments in regular mode * separate tests with modules
ikripaka
force-pushed
the
feat/fmt-parser
branch
from
July 23, 2026 17:45
3e6427e to
0cd4ac0
Compare
ikripaka
marked this pull request as ready for review
July 24, 2026 09:15
* the logic of parsing has to be consistent across all parsers
* fix problem with recognizing keywords in a comments, while we don't have to recognize them
* add test for lossless lexer, which checks that lossless lexer didn't lose anything from context * align tests with changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing of additional tokens for formatting
fmtfeature to separate logic for formatter parsingFmtTokens, which stores comments, newlines and whitespace dataToken,TriviaKind,FmtTokenas non-exhaustive