Repository navigation
fix(ci): forward CDK_PLATFORM_COSTS_ENABLED to the platform deploy - #1245
Merged
Merged
Conversation
config.ts reads it and the platform-cost-visibility spec tells operators to set it, but platform.yml never passed it through, so the GitHub variable had no effect and only cdk.json context could enable the sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Cherry-picked onto |
This was referenced Sep 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infrastructure/lib/config.tsreadsCDK_PLATFORM_COSTS_ENABLED(#1235) anddocs/specs/platform-cost-visibility.mdtells operators to set it for theplatform.ymldeploy, but the workflow never forwarded it. Setting the GitHub variable did nothing; onlyplatformCosts.enabledin cdk.json context could turn the sync on.This adds it to the
deployjob env, which is the only job inplatform.ymlthat runs synth/deploy and where every otherCDK_*var is forwarded.Safe when unset: an unset var arrives as
"", which is falsy inconfig.ts, so it falls back to theplatformCosts.enabledcontext (default off). Only the literal"true"enables the feature. Nothing changes for environments that set neither.Note for 1.24.0: the release notes on
release/1.24.0(#1244) say the variable isn't forwarded yet. That stays true unless this fix also lands on the release branch.No test asserts workflow env forwarding for other
CDK_*vars, so there was no existing test to extend.repo-shape.test.tsstill passes.🤖 Generated with Claude Code