Repository navigation
deserializer: unit fields shift later columns when using headers - #440
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
In map mode the key is read from the headers and the value from the record. `deserialize_unit` and `deserialize_unit_struct` never touched the record, so a `()` or unit struct field left its column unread and every field after it got the value of the column before it. Without headers nothing changes, so `PhantomData` fields there still don't take a column.
patrick-immometrica
marked this pull request as ready for review
November 14, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
()or unit struct field in a struct read with headers doesn't consume its column, so every field after it is off by one:In map mode the key comes from the headers, but
deserialize_unit/deserialize_unit_structnever read the value from the record. Same thing happens withPhantomData.The fix reads (and drops) the field when headers are in use. It doesn't fail if there's no field left, so deserializing an empty record as
()still works. Without headers nothing changes, since aPhantomDatafield there currently takes no column and people may rely on that.