Repository navigation
Conversation
CodeGat
changed the title
v4 for Special Repos: Support spack.repos, Add Tiered Common Configuration Via spack.includev4: Support spack.repos, Add Tiered Common Configuration Via spack.include
…g, deprecate spack-packages/datafile workflow inputs Assisted-by: Claude Fable 5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Whyborn
self-requested a review
September 24, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #740
Note
This PR incorporates major
build-cichanges into this CR, due to the deprecation ofinputs.*-spack-packages-refandinputs.spack-manifest-data-pathBackground
More info and motivations in the linked issue, but essentially:
inputs.*-spack-packages-refin favor of in-manfiestspack.repossection, like MDRs. By default, it will use the latestapi-v2foraccess-spack-packages, and the latestaccess/v1.1forbuiltinspack packages, but you're free to addrepossections as needed. If you need the exact commit for either, it is in the artifact for that particular run.inputs.spack-manifest-data-pathin favor of tiered configuration viaspack.include..github/build-ci/config/packages.yamlrather than in the datafiledata/standard.json, which is being deprecated.Note
Note the copilot co-author in the commit message - after a few manual updates for other CRs, I attempted to generalise the instructions for the other repos so it could be done quicker (this stuff usually takes me a couple days). But do note that I checked the changes with my human-eyes before committing :D
The PR
inputs.*-spack-packages-refs and transplant them into manifestsspack.repossectionsinputs.spack-manifest-data-pathand replace that withspack.includeentries, either from Add top-levelspack.includesdefault ACCESS-NRI/access-spack-packages#484 or a CR-level manifest to include.Testing
See below!
📚 Documentation preview 📚: https://cable--739.org.readthedocs.build/en/739/