Skip to content

nc_aborts exits with zero status - #743

Open
Whyborn wants to merge 1 commit into
mainfrom
fix-nc-abort-routine
Open

Whyborn wants to merge 1 commit into
mainfrom
fix-nc-abort-routine

Conversation

@Whyborn

@Whyborn Whyborn commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Change STOP statement to STOP 1 for error handling.

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

The nc_abort routine calls STOP without a value. This means that the caller treats this exit as a success, but it should be a failure.

Fixes #742

Type of change

Please delete options that are not relevant.

  • Bug fix

Checklist

  • The new content is accessible and located in the appropriate section
  • I have checked that links are valid and point to the intended content
  • I have checked my code/text and corrected any misspellings

Testing

  • Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.

📚 Documentation preview 📚: https://cable--743.org.readthedocs.build/en/743/

Change STOP statement to STOP 1 for error handling.
@Whyborn
Whyborn requested a review from abhaasgoyal September 28, 2026 05:46
@Whyborn Whyborn changed the title nc_aborts exits with non-zero status nc_aborts exits with zero status Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nc_abort fails without an error code

2 participants