Check for NVIDIA drivers and Wayland - then auto disable Accelerated Paint. - #26
Open
AmilieDev wants to merge 1 commit into
Open
Check for NVIDIA drivers and Wayland - then auto disable Accelerated Paint.#26AmilieDev wants to merge 1 commit into
AmilieDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
On NVIDIA + Wayland specifically, Accelerated Paint can be considered broken on these configurations, giving a blank screen / no render at all on NVIDIA / Wayland.
Solution:
The primary solution is to just disable Accelerated Paint altogether for NVIDIA + Wayland users at current. Until NVIDIA or the Wayland protocols push a fix, this is the only solution.
It works by detecting the GPU vendor with the existing isNvidiaGPU helper, and glfwGetPlatform() == Wayland, and then disables the feature by reporting back unsupported from checkLinuxSupport. XWayland instances are unaffected as they will report X11 regardless of GPU vendor.