Skip to content

[FIX] Segfault on files carrying both teletext and DVB subtitles #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Aug 13, 2026
+16 −1
Merged

[FIX] Segfault on files carrying both teletext and DVB subtitles #2319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/lib_ccx/lib_ccx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,11 @@ struct encoder_ctx *update_encoder_list_cinfo(struct lib_ccx_ctx *ctx, struct ca
return enc_ctx;
}

/* Nothing matched. list_for_each_entry() leaves the iterator pointing at the list
head reinterpreted as an encoder_ctx, which is not a usable encoder, so clear it
to let the code below tell "not found" apart from "found". */
enc_ctx = NULL;

const char *extension = get_file_extension(ccx_options.enc_cfg.write_format);
if (!extension && ccx_options.enc_cfg.write_format != CCX_OF_CURL)
return NULL;
Expand All @@ -487,7 +492,12 @@ struct encoder_ctx *update_encoder_list_cinfo(struct lib_ccx_ctx *ctx, struct ca
dvb_pid_count++;
}

if (dvb_pid_count >= 2)
/* Give the stream its own per-language encoder when there is more than one DVB
PID, or when some other stream (teletext, 608/708) already owns an encoder and
this DVB PID is an extra one alongside it. A recording whose only caption
stream is a single DVB PID still reaches the standard path below, because the
encoder list is empty on that first call, which keeps its filename unchanged. */
if (dvb_pid_count >= 2 || !list_empty(&ctx->enc_ctx_head))
{
struct encoder_cfg local_cfg = ccx_options.enc_cfg;
local_cfg.program_number = pn;
Expand Down Expand Up @@ -574,6 +584,11 @@ struct encoder_ctx *update_encoder_list_cinfo(struct lib_ccx_ctx *ctx, struct ca

list_add_tail(&(enc_ctx->list), &(ctx->enc_ctx_head));
}
/* No encoder was found or created. Report it rather than dereferencing the iterator
left behind by the search loop; callers already skip a NULL encoder. */
if (!enc_ctx)
return NULL;

// DVB related
enc_ctx->prev = NULL;
if (cinfo && cinfo->codec == CCX_CODEC_DVB && cinfo->lang[0])
Expand Down
Loading