Repository navigation
Remove unnecessary build flags on windows. - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the way the
MachineGeneratorexecutable target is defined inPackage.swift. The previous approach used conditional compilation to define the target differently for Windows and other platforms. The new implementation unifies the target definition and uses theswiftSettingsproperty to apply platform-specific compiler flags directly within the target declaration.Target definition simplification:
#if os(Windows)conditional compilation for defining theMachineGeneratortarget, consolidating both Windows and non-Windows logic into a single target declaration.swiftSettingsfor Windows (-parse-as-library) directly into the.executableTargetdeclaration using the.when(platforms: [.windows])modifier, ensuring platform-specific flags are applied cleanly.Codebase cleanup:
swiftSettingsfrom theGeneratorCommandstarget, streamlining the configuration.