feat: add rate limit on /api/proxy - #1122
Merged
Merged
Conversation
Closes CalloraOrg#950 Closes CalloraOrg#85
|
@Kaycee276 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat: Add per-user token-bucket rate limit on
/api/proxyDescription
This PR implements a per-user token-bucket rate limiting mechanism for the
/api/proxyroutes as outlined for the GrantFox FWC26 campaign. This enhancement ensures secure and controlled access to proxy endpoints by throwing a429 Too Many Requestserror and supplying aRetry-Afterheader when clients exceed their quota.Key Changes
src/middleware/rateLimit.ts):createProxyRateLimitMiddlewareleveraging theTokenBucketRateLimiter.userId-> RequestuserId-> Client IP.TooManyRequestsErrorenvelope along with calculatedRetry-Afterresponse headers.requestIdandretryAfterMs.src/routes/proxyRoutes.ts):proxyRateLimitacross all proxy route handlers (GET, POST, PATCH, DELETE, etc.).src/types/gateway.ts):proxyRateLimitrequest handler toProxyDepsallowing for injected mocks during tests.src/middleware/rateLimit.test.ts):429status code outputs.Quality Assurance & Security
logger.warnfor tracking rate-limit thresholds with correlation IDs attached.Closes #950