fix: stop enums masking - #191
Open
TimLeach635 wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
TimLeach635
force-pushed
the
fix/enum-masking
branch
from
July 1, 2026 15:33
4b23540 to
de4e8ff
Compare
Member
|
Ah, but these are the same thing, with a different name. I think actually removing NOISY_RECON may be best instead |
Contributor
Author
Fantastic - see, this is exactly the kind of thing AI fails to spot!! I'll give removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these two enums were both being represented by the same underlying integer, meaning they couldn't be differentiated from each other. This fix means they can now actually be separated!
Co-authored by Claude Code (Sonnet 5), reviewed by me