Repository navigation
fix: rename from the provider's current name, so CI's rename check passes - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in the template's fix (anolishq/anolis-provider-template-python#3). CI's "Rename still builds" job failed on
main(1ca8b57), becauserename.shstill renamed from the template's name:scripts/rename.sh: the template's fixed script, copied as is. It reads the current name frompyproject.tomland holds no provider name, so it's identical in every provider.ci.yml: the rename job renames twice, as in the template.Verification
hello-python→renamed-once→renamed-check: both runs exit 0, leavingsrc/anolis_provider_renamed_check.ci.ymlequals the template's fixed workflow with the template's name replaced by this one.