fix(cli): preserve detected iOS target in Builder onboarding - #3202
fix(cli): preserve detected iOS target in Builder onboarding#3202WcaleNieWolny wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Merging this PR will not alter performance
Comparing Footnotes
|
dimin4241-svg
left a comment
There was a problem hiding this comment.
The selected Xcode target needs to follow the effective provisioning bundle ID.
| const distribution = isImport ? (progress.importDistribution || 'app_store') : 'app_store' | ||
| let iosTarget: string | undefined | ||
| try { | ||
| iosTarget = deps.detectBundleIds?.().iosTarget ?? undefined |
There was a problem hiding this comment.
This ignores the effective provisioningBundleId resolved just above. When a user has verified progress.iosBundleIdOverride, the provisioning map is keyed by that override, but CAPGO_IOS_TARGET still comes from the detector’s original Release-ID candidate. In a multi-application project this can make Builder choose one target while supplying a profile for another. Please resolve the target against provisioningBundleId (or omit the override unless they match), and extend the existing override-priority test to assert CAPGO_IOS_TARGET too.



Summary
CAPGO_IOS_TARGETduring iOS Builder onboardingApptarget during marketing-version handlingDinnerish/com.dinnerish.appcase with multiple application targetsTesting
bun run cli:checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.