fix(login): one password-manager prompt, one submit button - #3217
Draft
riderx wants to merge 1 commit into
Draft
Conversation
Opacity-0 / 1px fields are skipped by Apple Passwords and Bitwarden, so email, password, and TOTP stay visible until SSO. One submit button so 2FA no longer shows Log in and Verify together. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Contributor
Visual diff passedVisual changesGenerated at 2026-08-26T15:33:16.974Z. Threshold: 0.1% pixel difference.
Commit: Open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary (AI generated)
Motivation (AI generated)
The merged login kept password and TOTP at 1px / opacity 0 until later steps. Password managers ignore those fields, so users still got a second prompt. On 2FA, Log in stayed visible next to Verify because
passwordPathReadynever cleared.Business Impact (AI generated)
Fewer abandoned console logins for people using a password manager, including 2FA. SSO orgs still only see Continue with SSO.
Visual changes (AI generated)
Live screenshots from the running login page.
First paint
Email, password, and 2FA are all visible. One Log in button.
SSO login
SSO domains hide password and 2FA. Continue with SSO only.
2FA
After password auth, only the TOTP field and Verify. No second Log in button.
Test Plan (AI generated)
/login/and see email, password, and 2FA together, with one Log in buttonauth.spec.tsandsso-login.spec.tspassGenerated with AI
Made with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.