Skip to content

fix(login): one password-manager prompt, one submit button - #3217

Draft
riderx wants to merge 1 commit into
mainfrom
fix/login-one-password-manager-prompt
Draft

fix(login): one password-manager prompt, one submit button#3217
riderx wants to merge 1 commit into
mainfrom
fix/login-one-password-manager-prompt

Conversation

@riderx

@riderx riderx commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary (AI generated)

  • Email, password, and 2FA stay visible in one form so Apple Passwords / Bitwarden can fill them in a single prompt
  • Opacity-0 / 1px fields are skipped by password managers, so that hiding trick is gone
  • Hide password + 2FA only after the domain is confirmed SSO
  • One submit button: Log in on the login step, Verify on 2FA. No more both at once

Motivation (AI generated)

The merged login kept password and TOTP at 1px / opacity 0 until later steps. Password managers ignore those fields, so users still got a second prompt. On 2FA, Log in stayed visible next to Verify because passwordPathReady never cleared.

Business Impact (AI generated)

Fewer abandoned console logins for people using a password manager, including 2FA. SSO orgs still only see Continue with SSO.

Visual changes (AI generated)

Live screenshots from the running login page.

First paint

Email, password, and 2FA are all visible. One Log in button.

Email password 2FA

SSO login

SSO domains hide password and 2FA. Continue with SSO only.

SSO login

2FA

After password auth, only the TOTP field and Verify. No second Log in button.

2FA login

Test Plan (AI generated)

  • Open /login/ and see email, password, and 2FA together, with one Log in button
  • Password manager fills email, password, and TOTP from one prompt
  • SSO domain: password and 2FA hide, Continue with SSO only
  • After password auth with MFA: only Verify, not Log in + Verify
  • Playwright auth.spec.ts and sso-login.spec.ts pass

Generated with AI

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Review in cubic

Opacity-0 / 1px fields are skipped by Apple Passwords and Bitwarden, so
email, password, and TOTP stay visible until SSO. One submit button so
2FA no longer shows Log in and Verify together.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@riderx
riderx deployed to deepsec-pr August 26, 2026 15:20 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Visual diff passed

Visual changes

Generated at 2026-08-26T15:33:16.974Z. Threshold: 0.1% pixel difference.

Route Diff % Status
login 14.238 changed
dashboard 36.150 changed
account-settings 0.000 unchanged
organization-credits 0.000 unchanged
apps 0.052 unchanged
apps-sidebar-collapsed 0.052 unchanged
app-overview 2.710 changed
app-dashboard-native 0.089 unchanged
app-dashboard-installs 1.428 changed
app-dashboard-active-bundle 0.503 changed
app-getting-started 0.163 changed
app-settings 0.000 unchanged
app-settings-access 2.174 changed
org-settings 0.000 unchanged
org-settings-team 0.009 unchanged
org-settings-billing 0.074 unchanged
channels 0.027 unchanged
devices 0.000 unchanged
observe 0.082 unchanged
observe-logs 0.000 unchanged
observe-native 0.000 unchanged
observe-compatibility 0.000 unchanged
observe-plugins 0.000 unchanged
channel-statistics 1.339 changed
api-keys-app-preview 2.113 changed

Commit: 1528be16dbbc012b0399a9fd30192d144da94cc3
Download the HTML report from workflow artifacts (artifact: visual-diff-report-1528be16dbbc012b0399a9fd30192d144da94cc3).

Open index.html from the artifact for side-by-side before/after/diff screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant