Repository navigation
Close gaps in the GPX and repeat-route tests - #30
Merged
Merged
Conversation
Mutations run against #28 survived these tests: export.gpx coordinates, thinning on import, and the new-road flag changing during a track. The tests now compare export-all and re-imported points, require thinning, drive a detour off known road and back, and end a track by stopping. Story: CHOMP-3 Story: CHOMP-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #28. Mutation runs on PostGIS found breaks its tests missed. Test code only.
Now covered:
export.gpxand re-imported points are compared with what was senttrack_idleends the track/api/healthfixes must equal the stored count exactlyEvidence, run on Murph at e7d8387 (Postgres 17.6 / PostGIS 3.5.3, not the CI image): baseline passes, and each mutation fails only the intended check.
api.rs:387single-track export coordinatesapi.rs:1146api.rs:451import coordinatesapi.rs:1146api.rs:585export-all coordinatesapi.rs:1189recorder.rs:168road checked once per trackrecorder.rs:603api.rs:461no thinning on importapi.rs:1170recorder.rs:142idle never ends a trackrecorder.rs:621Not covered: the local idle deadline in
run()(receiver unplugged). The CI step stays on plain--ignored: the old--exactform also passes with 0 tests when the name is missing, confirmed by running it.Neither story finishes here: CHOMP-3 still needs a real TNC, and CHOMP-5 still needs the update upload on the reTerminal.
Story: CHOMP-3
Story: CHOMP-5
🤖 Generated with Claude Code