Repository navigation
Cap new-IP scans in paradox watch and file the threat model's gaps - #26
Merged
Merged
Conversation
A log can name endless forged addresses, and each scan spends quota, so the watcher now scans at most 15 new IPs an hour. PDX-34 to PDX-37 file the other gaps found while writing SECURITY.md. Story: PDX-33 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: PDX-33
paradox watchscanned each new public IP it saw, so forged source addresses in a log could spend the day's VirusTotal lookups. It now scans at most 15 new IPs an hour (--max-new-per-hour,0for no limit). Rescans aren't counted. An IP over the limit is scanned when it's seen again after the hour.Also files the threat model's other gaps as PDX-34 to PDX-37, as the watchman asked. Those aren't built here.
Behaviour change
A busy log that sees more than 15 new IPs an hour now scans fewer of them. Use
--max-new-per-hourto change that.Downsides
Tested
Watcher.feedfrom piped lines with a stubbed scanner: capped as expected.Not tested
A real log, a long run, or the live beacons.
🤖 Generated with Claude Code