Skip to content

Keep raw log lines out of webhook posts (roadmap 4.7) - #27

Merged
Castor-o7 merged 1 commit into
mainfrom
pdx-34-webhook-log-lines
Oct 31, 2026
Merged

Castor-o7 merged 1 commit into
mainfrom
pdx-34-webhook-log-lines

Conversation

@Castor-o7

Copy link
Copy Markdown
Owner

Story: PDX-34

A webhook post no longer includes alert.sample, the raw log line. A log line can hold usernames, internal hostnames or tokens, and a webhook goes to a third party. --json stdout keeps it for local use.

Behaviour change

A receiver that read alert.sample no longer gets it.

Limits

A post still says which IPs were seen, how often, and the log's path (source).

Tested

  • 169 tests pass locally. See CI for other versions.
  • The test captures the bytes handed to urlopen: the log line's text is absent and sample is gone, while stdout still has it. With the removal undone, the test fails.

Not tested

A post to a real Slack or Mattermost webhook.

🤖 Generated with Claude Code

A log line can hold usernames, hostnames or tokens, and a webhook goes to a
third party. The sample line now stays in --json stdout only.

Story: PDX-34

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Castor-o7
Castor-o7 merged commit d6df197 into main Oct 31, 2026
5 checks passed
@Castor-o7
Castor-o7 deleted the pdx-34-webhook-log-lines branch October 31, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant