Repository navigation
Keep raw log lines out of webhook posts (roadmap 4.7) - #27
Merged
Merged
Conversation
A log line can hold usernames, hostnames or tokens, and a webhook goes to a third party. The sample line now stays in --json stdout only. Story: PDX-34 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: PDX-34
A webhook post no longer includes
alert.sample, the raw log line. A log line can hold usernames, internal hostnames or tokens, and a webhook goes to a third party.--jsonstdout keeps it for local use.Behaviour change
A receiver that read
alert.sampleno longer gets it.Limits
A post still says which IPs were seen, how often, and the log's path (
source).Tested
urlopen: the log line's text is absent andsampleis gone, while stdout still has it. With the removal undone, the test fails.Not tested
A post to a real Slack or Mattermost webhook.
🤖 Generated with Claude Code