Skip to content

Refuse unencrypted webhooks (roadmap 4.9) - #29

Merged
Castor-o7 merged 1 commit into
mainfrom
pdx-36-https-webhooks
Oct 31, 2026
Merged

Castor-o7 merged 1 commit into
mainfrom
pdx-36-https-webhooks

Conversation

@Castor-o7

Copy link
Copy Markdown
Owner

Story: PDX-36

paradox watch now exits with status 2 if its webhook isn't https://, or http:// on loopback. PARADOX_WEBHOOK_ALLOW_HTTP=1 allows other http:// URLs. Other schemes such as file:// and ftp:// are always refused, which also closes off urllib reading or posting to them. The refusal doesn't quote the URL.

Behaviour change

A setup using a plain http:// webhook now fails at startup until it switches or sets the override.

Limits

A server's redirect is followed without this check, and the override allows unencrypted posts.

Tested

Full suite passes locally; see CI for other versions. Tests cover https, loopback forms, a lookalike host (127.0.0.1.example.test), file, ftp, missing host, the override, and that messages omit the URL. With the startup check removed the CLI test fails, and it passes with the code intact. The real CLI refused http://example.test/secret with exit 2.

Not tested

A real post to any webhook.

🤖 Generated with Claude Code

The watcher won't start with a webhook that isn't https://, or http:// on
loopback, unless PARADOX_WEBHOOK_ALLOW_HTTP=1 is set. Other schemes, such as
file://, are always refused. The refusal doesn't quote the URL.

Story: PDX-36

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Castor-o7
Castor-o7 merged commit 4308d64 into main Oct 31, 2026
5 checks passed
@Castor-o7
Castor-o7 deleted the pdx-36-https-webhooks branch October 31, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant