Repository navigation
Refuse unencrypted webhooks (roadmap 4.9) - #29
Merged
Merged
Conversation
The watcher won't start with a webhook that isn't https://, or http:// on loopback, unless PARADOX_WEBHOOK_ALLOW_HTTP=1 is set. Other schemes, such as file://, are always refused. The refusal doesn't quote the URL. Story: PDX-36 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: PDX-36
paradox watchnow exits with status 2 if its webhook isn'thttps://, orhttp://on loopback.PARADOX_WEBHOOK_ALLOW_HTTP=1allows otherhttp://URLs. Other schemes such asfile://andftp://are always refused, which also closes off urllib reading or posting to them. The refusal doesn't quote the URL.Behaviour change
A setup using a plain
http://webhook now fails at startup until it switches or sets the override.Limits
A server's redirect is followed without this check, and the override allows unencrypted posts.
Tested
Full suite passes locally; see CI for other versions. Tests cover https, loopback forms, a lookalike host (
127.0.0.1.example.test),file,ftp, missing host, the override, and that messages omit the URL. With the startup check removed the CLI test fails, and it passes with the code intact. The real CLI refusedhttp://example.test/secretwith exit 2.Not tested
A real post to any webhook.
🤖 Generated with Claude Code