Repository navigation
RAL-190: the board-ages browser test waits for the board's first draw - #277
Merged
Merged
Conversation
Hosted `check` on PR #275 failed once at the_board_keeps_its_ages_current_and_shows_commits_short: its probe read `before: []`, then five ages 2.5 s later, with "updated 2s ago". The cause: the board draws from the page's own fetch of /api/status, and the load event that sign-in.mjs waits on doesn't wait for that fetch. On Murph the first draw beat the probe by about 20 ms (measured: drawn at ~45 ms, probe at ~65 ms), and on a loaded runner it lost. Holding the page's first /api/status for 600 ms through CDP's Fetch domain (a local change, not committed) reproduced the failure exactly; load alone on Murph didn't in 42 runs. The product is right: a board can't show ages before it has read any, and it shows them as soon as it has. The test raced it, so the fix is in the harness, for every probe: before a probe, wait up to 20 s for the board's first draw (`drawnAt`, set once `show` has drawn) or the page's own warning, and report which as `firstDraw`. The ages test asserts "drawn". With the 600 ms and 3 s holds it now passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # tests/browser/sign-in.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-190, from the watchman: the one-off hosted failure on #275 (
before: []).Cause: the board draws from the page's own /api/status fetch, which the load event sign-in.mjs waits on does not wait for. The margin on Murph is about 20 ms. Reproduced by holding the page's first /api/status for 600 ms via CDP Fetch (local only).
Product right, test raced: the harness now waits before any probe for the first draw (
drawnAt) or the page's warning, and reportsfirstDraw. The ages test asserts "drawn". It passes with 600 ms and 3 s holds.🤖 Generated with Claude Code