Repository navigation
Conversation
…s gone /proc/locks names the process that took a lock; dsm-heavy's bash takes the slot and execs systemd-run --scope, and under systemd 261 the job doesn't keep that pid, so every dsm-heavy holder read as a pid that had exited, and stalls' stopped and possibly-hung checks never prompted for one (issues log 1.86). When the kernel's holder is gone or doesn't have the file open, the holders are the topmost processes with an open descriptor on it, by device and inode through /proc/<pid>/fd; the row says found_by and keeps kernel_holders; none found is a blind spot naming how many processes couldn't be read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From RAL-191's first live run on Murph (issues log 1.86): every dsm-heavy slot's holder by /proc/locks was a pid that had exited. /proc/locks keeps the pid of the process that took the flock, dsm-heavy's own bash; under systemd 261
exec systemd-run --scopedoesn't leave the job on that pid, and the job's processes hold the lock by the inherited open file description. Solock_holder::readwalked a process that didn't exist, and stalls' stopped-holder (RAL-75) and possibly-hung (RAL-163) checks never prompted for a dsm-heavy job.lock_holder::read: when a holder /proc/locks names has exited or doesn't have the file open, every user-space process's/proc/<pid>/fdis read for a link naming the lock file whose target has its device and inode; the holders are the topmost of those (whose parent doesn't hold it too). The row saysfound_byand keepskernel_holders, withunreadable_processeswhen some couldn't be read (kernel threads aren't counted).--prompts-only, RAL-174).in_flight(RAL-191) shows the same fields.topmostunit test; a service test where a shell takes the lock, startssleep 60with the descriptor and exits: the holder is the sleep's pid, found by descriptor, kernel pid kept, and bothpossibly_hung_lock_holderand (after SIGSTOP)stopped_lock_holderprompt for it.🤖 Generated with Claude Code