Repository navigation
RAL-194: one walk of every process's open files for a pass; sh's exit status ahead of a broken pipe - #282
Merged
Conversation
… status ahead of a broken pipe (a) Each lock whose taker had exited walked every process's /proc/<pid>/fd for itself. A lock_holder::Pass now shares one walk across all the locks of a stalls or in_flight pass. Each process the walk names is still checked afresh by device and inode, and a lock the walk found nothing for is looked for alone before it's called a blind spot. (b) script::write returned the failed send (Broken pipe) ahead of sh's exit status when sh couldn't open the file and the text was too long for the pipe. The exit status now comes first, with the failed send beside it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to RAL-192 and RAL-189.
(a) One walk for a pass
Each lock whose taker had exited walked every process's
/proc/<pid>/fdfor itself, so a pass over many slots walked them once per slot, and the possibly-hung check twice that.lock_holder::Passshares one walk across all the locks of a pass.rally stallsuses one pass per sample; the brief'sin_flightuses one over every project's locks.lock_holder::readis unchanged for callers: a pass of its own.(b) sh's exit status first
script::writereturned the failed send ("Broken pipe") ahead of sh's exit status when sh couldn't open the file and the text was too long for the pipe. The exit status now comes first, with the failed send beside it.Tests
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass locally. On this machine the brief'sin_flightreads the same 10 held locks as the installed CLI.docs/roadmap.mdwill conflict with #281 (both add an entry at the end); I'll merge main in once that lands.🤖 Generated with Claude Code