Park pinned objects at their anchors while modals are open (suppressPins API) - #30
Merged
Merged
Conversation
While stage._pinsHidden is set, pinned objects now drop back into their regular spot in the display list (under an open modal) instead of being hidden, and lift back when the flag clears.
…ins) Register a modal's container with easelbone.suppressPins(obj): while it is on the stage, pins are parked at their anchors; they lift back when the modal leaves (or on explicit releasePins). Nests across multiple modals, expires never-attached registrations after ~5s, and writes stage._pinsHidden for cross-bundle compatibility.
|
📦 PR Preview deployed! Examples are available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stage._pinsHiddennow parks pinned objects back into their anchors (regular spot, regular z-order under the modal) instead of hiding their wrappers; they lift back when suppression ends.easelbone.suppressPins(obj)registers a modal-like display object — while it is attached to a stage, that stage's pins are parked. Auto-releases when the object leaves the stage;easelbone.releasePins(obj)for modals that linger on stage after closing._deferPin), and keeps writingstage._pinsHiddenso older easelbone copies sharing the stage stay protocol-compatible.Testing
npm run test:pin:suppress(fixturetools/fixtures/pin-suppress.html) — parking via manual flag, pin-while-suppressed, attach/detach auto-release, nesting, explicit release, grace expiry.smokeexample-page failures (16) are pre-existing on master, unrelated to this change.test:baseline,test:pin,test:pin:placeholderall pass.Consumed by CatLabInteractive/catlab-remote-library PR: pin-suppression-parking.
🤖 Generated with Claude Code