Skip to content

Harden Action and add pages, cache and php_version inputs - #5

Merged
ArnaudLigny merged 1 commit into
masterfrom
improve-action
Oct 28, 2026
Merged

ArnaudLigny merged 1 commit into
masterfrom
improve-action

Conversation

@ArnaudLigny

Copy link
Copy Markdown
Member

Fixes

  • Inputs are passed through env vars instead of ${{ }} interpolation in scripts (script injection).
  • Pinned versions are downloaded from GitHub releases: cecil.app/download/8.x/cecil.phar returns 404.
  • curl -f so a failed download is reported; phar stored in $RUNNER_TEMP.
  • PHP defaults to 8.3 instead of pre-installed (8.1 on ubuntu-22.04, Cecil 9 requires 8.3+).
  • Step summary shows the actual Cecil version; useless $? check removed.
  • --baseurl is only added when not already in options.
  • composer install no longer --quiet (errors were hidden).
  • README uses Cecilapp/Action instead of the redirected Cecilapp/Cecil-Action.

Improvements

  • pages input (default true) to skip GitHub Pages setup/upload.
  • cache input (default true): Composer and Cecil .cache caching.
  • SHA-1 checksum verification when published (warning otherwise).
  • php_version input; boolean inputs accept yes/true/1/on.
  • output_dir and cecil_version outputs; explicit error when output dir is missing.
  • Tests run on PRs with an Ubuntu/macOS/Windows matrix and a path + pinned version + --output case.

Since the default PHP version changes, this should be released as a minor version (4.2.0).

🤖 Generated with Claude Code

…utputs

- pass inputs through env vars to prevent script injection
- download pinned versions from GitHub releases (cecil.app no longer hosts < 9)
- fail on download errors, verify SHA-1 checksum when available
- default PHP to 8.3 (Cecil 9 requirement), configurable via php_version
- add optional pages and cache inputs, output_dir and cecil_version outputs
- don't override user-provided --baseurl, show Composer errors
- test on Ubuntu, macOS and Windows, run on pull requests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ArnaudLigny
ArnaudLigny merged commit b6268f7 into master Oct 28, 2026
6 checks passed
@ArnaudLigny
ArnaudLigny deleted the improve-action branch October 28, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant