Fix versioned entry witness placement ABI - #3
Closed
a19q3 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cellscript-witnessargs-input-type-v2placement contract for generated CKB entry wrappersCSARGv1compatibility while strictly decoding canonical three-fieldWitnessArgsand selecting onlyinput_typeProblem
Generated action entry wrappers previously loaded the raw witness at transaction-global input 0. That is incorrect for script groups whose first input is not input 0, and it collides with canonical CKB lock witnesses because a signing lock owns
WitnessArgs.lock.ABI and compatibility
For the CKB target profile, a versioned entry payload is placed in
WitnessArgs.input_type. The generated wrapper uses group input 0 and falls back to group output 0 only for output-only type groups. It never aliasesoutput_type. RawCSARGv1remains accepted for compatibility. Malformed or non-canonicalWitnessArgsfails closed with entry decode error 25.The adapter placement API preserves an existing lock field and refuses an already occupied
input_typefield.Verification
./scripts/cellscript_gate.sh dev./scripts/cellscript_gate.sh cif7fa443with direct node acceptanceThe generated token-transfer ELF remains within the existing 7,168-byte backend budget.
Downstream integration: Myelin-Labs/Myelin@7deb8e9