Repository navigation
[scripts] Treat missing legacy raster CRS as a warning - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy TUFLOW FLT and ASC outputs may omit
.prjfiles. PR #107's strict CRS check incorrectly reports those as mismatches even when cell values, NoData masks, and grid alignment are identical.Change
MATCH_CRS_UNVERIFIED(eligible for the deletion proposal, with explicit uncertainty).tuflow_raster_conversion_warnings.csv; includestatusandwarningcolumns on proposed deletions..prjfiles.Tests
Caution
A warning indicates that the spatial reference is not independently proven, even when stored grid geometry and pixel values match. Review any warning-labelled deletion candidates before approving deletion. No project data was accessed or changed.