Skip to content

[packaging] Curate installed scripts and reconcile MCP distribution requirements - #130

Merged
Chain-Frost merged 28 commits into
mainfrom
planning/pip-scripts-mcp-distribution-20261017
Oct 18, 2026
Merged

Chain-Frost merged 28 commits into
mainfrom
planning/pip-scripts-mcp-distribution-20261017

Conversation

@Chain-Frost

@Chain-Frost Chain-Frost commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Purpose

Reconcile the original installed-scripts/MCP/distribution architecture plan with the implementation already merged into main, then close the remaining wheel curation and project-copy gaps. This is now an implementation PR, not a deferred-only document.

PRs #118 and #119 are independent and are not blockers. PRs #100, #120 and #129 have already merged.

Authoritative updated requirements and status: docs/work/2026-10-17-installed-scripts-mcp-pip-distribution.md.

Existing implementation retained (reviewed against requirements)

  • ryan-tools is the PyPI distribution while ryan_library remains the Python import name; legacy aliases were explicitly retired in Install QGIS MCP and PyPI user installer with conditional Codex setup #120.
  • Comprehensive default engineering/GIS dependency installation remains intentional.
  • Python 3.13+ remains supported, including ryan-culverts (later maintainer decision supersedes the former tentative November 3.14-only plan).
  • run-hy8 and ryan-culverts are separately installed pip dependencies; source hydraulic submodules are already removed.
  • Installed ryan-scripts and discovery-only ryan-mcp work without a checkout. Capability profiles, mutation approval metadata and bounded listing are preserved.
  • No direct unapproved run_workflow is added.

New code in this PR

  • Explicit, reviewed 83-file installed script allowlist, encompassing all 33 distinct existing MCP script targets while leaving 63 unreviewed/legacy source files repository-only.
  • Wheel builder stages only those files; verifier rejects missing, unexpected and non-byte-identical script members.
  • New ryan-scripts list / ryan-scripts copy CLI to locate original copyable files and safely copy to an existing project folder, with explicit overwrite and dry-run support.
  • Focused packaging and CLI tests and installed-wheel smoke tests, plus updated MCP, wrapper and work-plan documentation.
  • Nonblocking tracked follow-ups for external Windows/QGIS/TUFLOW/HY-8 engineering acceptance and other repository-only wrapper reviews.

Validation required before merge

  • All five required checks pass at the exact final head (Ruff, Policy, Hosted tests, Package, Python 3.13/MCP).
  • Curated wheel member verification and the isolated no-checkout installed-wheel test pass.
  • Documentation/link checks and head SHA reviewed.
  • Mark this PR ready and squash merge only after those checks, without forcing bypass.

Publication: This PR includes package changes; follow the repository's normal verified post-merge publishing policy. Do not manually publish/deletе releases or make unrelated installer changes.

No direct MCP execution, no Python 3.14-only policy, and no implementation from #118/#119 is being merged here.

Preserve latest main changes and the deferred planning index; reconcile completed PR #100/#129 work records.
@Chain-Frost Chain-Frost changed the title [planning] Package maintained scripts for pip-installed MCP workflows and modernise distribution [packaging] Curate installed scripts and reconcile MCP distribution requirements Oct 18, 2026
@Chain-Frost
Chain-Frost marked this pull request as ready for review October 18, 2026 16:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T16:56:54.150960Z 21eef0a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chain-Frost
Chain-Frost merged commit 1ac42c6 into main Oct 18, 2026
5 checks passed
@Chain-Frost
Chain-Frost deleted the planning/pip-scripts-mcp-distribution-20261017 branch October 18, 2026 16:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21eef0a314

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ryan_library/mcp/installed_scripts.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant