fix: fail closed when proof-of-life has no burst frames - #441
Merged
kilodesodiq-arch merged 4 commits intoAug 22, 2026
Merged
Conversation
Selfie-only requests (no burst frames) previously passed liveness because the burst_required flag defaulted to satisfied when no frames were supplied, collapsing the anti-spoon signal to 'a face is present'. Make liveness evidence a mandatory precondition: without burst frames, is_real_person is always false with a clear reason. Burst- based requests are scored on actual blink/head-movement evidence. Closes ChainForgee#431
The conftest was replacing proof_of_life with a MagicMock at module level, causing all tests to get MagicMock objects instead of real classes. The cascade classifier loading happens in __init__ (not at module level), so the stub is unnecessary with mocked cv2.
Without mocking _detect_primary_face, the mock cv2 cascade returns no faces, causing analyze() to return 'No face detected' before reaching the burst-required liveness check. Adding the mock ensures the selfie-only tests exercise the correct code path.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selfie-only requests (no burst frames) previously passed liveness because the burst_required flag defaulted to satisfied when no frames were supplied, collapsing the anti-fraud signal to "a face is present".
Make liveness evidence a mandatory precondition: without burst frames, is_real_person is always false with a clear reason. Burst-based requests are scored on actual blink/head-movement evidence.
Closes #431
Testing
Checklist